Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DolphinQt/InputCommon: Fix a few memory leaks. #7906

Merged
merged 1 commit into from Mar 21, 2019

Conversation

3 participants
@jordan-woyak
Copy link
Member

jordan-woyak commented Mar 17, 2019

Qt's setModel, setMenu, and installEventFilter do not take ownership of the passed QObject so the parents must be set manually.

Manually added parents to some widgets that were created but conditionally added to the layout.

And InputCommon's evdev code was leaking some udev handles.

@jordan-woyak jordan-woyak force-pushed the jordan-woyak:leak-fix branch from 339cbaa to a78d238 Mar 17, 2019

@jordan-woyak jordan-woyak force-pushed the jordan-woyak:leak-fix branch from a78d238 to 725d34b Mar 17, 2019

@Tilka Tilka merged commit 0a1aacb into dolphin-emu:master Mar 21, 2019

9 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details

@jordan-woyak jordan-woyak deleted the jordan-woyak:leak-fix branch Mar 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.