[WIP] Logging / DolphinQt: Manage different log levels for each log source #7911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(with inheritance for simplified use)
BhaaLseN
reviewed
Mar 18, 2019
| LWARNING = 3, // Something is suspicious. | ||
| LINFO = 4, // General information. | ||
| LDEBUG = 5, // Detailed debugging - might make things slow. | ||
| LSUPPRESS = 0, // don't show any logs in this category (don't use this for generating logs, only |
There was a problem hiding this comment.
It would probably be a good idea to move those comments to the line before. At least Visual Studio will show them as code comment in IntelliSense that way.
There was a problem hiding this comment.
Only for the long ones that don't fit into the line or also for the short ones?
There was a problem hiding this comment.
For consistency, all of them; for the same reason - they show up in IntelliSense. Not sure if everyone agrees tho.
|
Please move the |
…source (with inheritance for simplified use)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.