Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Fix touch IR #7921

Merged
merged 3 commits into from Apr 1, 2019

Conversation

5 participants
@zackhow
Copy link
Member

commented Mar 23, 2019

This fixes touch IR after improvements from PR7829.

Also I've removed the game specific IR values. Most games map fine with the default values and I have yet to read a single complaint on mapping the touch pointer. Going to just leave it up to the users to setup mapping if the defaults don't work for a specific game. @Helios747 You were right :)

@zackhow zackhow force-pushed the zackhow:fixir branch from 66ba5ac to 2fab8d6 Mar 23, 2019

zackhow added some commits Mar 23, 2019

Android: Remove game specific IR values
Most games map fine with the default values and I have yet to read a single
complaint on mapping the touch pointer. Going to just leave it up to the users
to setup mapping if the defaults are not correct.

@zackhow zackhow force-pushed the zackhow:fixir branch from 2fab8d6 to fd323e7 Mar 23, 2019

@jordan-woyak

This comment has been minimized.

Copy link
Member

commented Mar 23, 2019

I'm going to add some IR calibration logic which will move the in game cursor to maybe 3 or 4 select positions on the screen for the user to click/touch so the ideal Width/Height/Center settings can be calculated.

I don't know if the game specific IR values should be removed or not. There are definitely some games that are going to need non-default values (Skyward Sword, for one).

@zackhow

This comment has been minimized.

Copy link
Member Author

commented Mar 23, 2019

I'm going to add some IR calibration logic which will move the in game cursor to maybe 3 or 4 select positions on the screen for the user to click/touch so the ideal Width/Height/Center settings can be calculated.

I don't know if the game specific IR values should be removed or not. There are definitely some games that are going to need non-default values (Skyward Sword, for one).

We can cross that bridge when we come to it. I'm just putting this up so we don't tag a beta with broken touch pointer.

On the topic of game specific values, I looked over the forums and playstore reviews and didn't find a mention(after PR7500 was merged) of anyone complaining about the touch pointer not mapping 1-1. Seems that the users are able to do the mapping themselves when needed. I think this also plays into the fact that all mappings would need to be updated when any axis logic changes(like in pr7829).

@JMC47

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2019

@stenzek

stenzek approved these changes Apr 1, 2019

Copy link
Contributor

left a comment

Code changes seem fine.

@JMC47 JMC47 merged commit 42964e8 into dolphin-emu:master Apr 1, 2019

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.