Add a Verify tab to game properties #7922
Conversation
|
Seems like lint doesn't understand that a CJK character isn't three columns wide just because it takes up 3 bytes in UTF-8. Oh well. |
| const DiscIO::VolumeVerifier::Problem problem = result.problems[i]; | ||
|
|
||
| QString severity; | ||
| switch (problem.severity) |
There was a problem hiding this comment.
Do we want to use shading or text color to indicate severity as well, or should we just leave it as normal text?
There was a problem hiding this comment.
@MayImilae, any thoughts?
| const IOS::ES::TMDReader& tmd = m_volume.GetTMD(m_volume.GetGamePartition()); | ||
| if (tmd.IsValid()) | ||
| { | ||
| const std::string correct_ios = "IOS" + std::to_string(tmd.GetIOSId() & 0xFF) + "-"; |
There was a problem hiding this comment.
Note to self: Dash at the end to avoid partial matches. File names are "IOS nn-xx-v vv.wad"
There was a problem hiding this comment.
By the way, do you know what the xx stands for? It seems to always be 64, but I'm not sure why.
There was a problem hiding this comment.
I'm afraid not. Maybe 64-bit? No idea.
JosJuice
force-pushed
the
verify-disc
branch
2 times, most recently
from
5d5d131
to
063543e
Compare
Also added constants for common partition types.
|
This is what it looks like with hash calculation integrated:
|
JosJuice
force-pushed
the
verify-disc
branch
3 times, most recently
from
f374834
to
381c289
Compare
JosJuice
changed the title
|
This PR should be feature complete now. |
JosJuice
force-pushed
the
verify-disc
branch
3 times, most recently
from
b7b6dbc
to
0c46441
Compare
JosJuice
force-pushed
the
verify-disc
branch
2 times, most recently
from
282e6a2
to
6b966ab
Compare
There was a problem hiding this comment.
It seems to be working for me. I tried it with my GC, Wii, WAD and exotic games such as DQX, SSBB.
I didn't have any issue with those. It also warned me with the ones I modded due to missing update partitions and other issues like missing files and so on.
The checksum calculation matches the one from redump regarding my games which didn't have verification problem.
Overall, LGTM.
|
Could you set the window to not require scrolling for the tabs? On Windows the window is wide enough for everything except GameCube games. |
|
Hmm... Is there a good way to do that other than just making the window wider? And if we make it wider, should we make it wide enough for all languages or just some? In master, it's wide enough for English but not all other languages. cc @spycrab |
| return Region::NTSC_U; // The most common country code for NTSC-U | ||
|
|
||
| if (revision) | ||
| { | ||
| if (*revision >= 0x30) |
There was a problem hiding this comment.
Is there an appropriate upper bound that can be set here? I believe that a lot of homebrew likes to set funny revision numbers.
There was a problem hiding this comment.
It would be possible to put some kind of limit on it, but there's no specific number that's the right one. I'm not especially concerned about this, since the intention behind the feature is that it lets you check if you have a correct dump or not, and homebrew releases are not correct dumps, so I'm okay with showing errors for them even if the description isn't quite accurate.
This PR adds a new tab to the game properties window where you can check for problems with your games. Hopefully this can cut down a bit on people who ask about problems that turn out to be caused by bad dumps. For instance, there's a message about not having combined the files that CleanRip produces, and there's a message you get if you've pirated a single-layer version of a game that's supposed to be dual-layer. Some screenshots to show what it looks like:
My good dump of Rodea the Sky Soldier (NTSC-K):
The same game but with the IOS slot hex edited to reproduce https://bugs.dolphin-emu.org/issues/10319:
This is a WIP for now, but feel free to review, as long as it isn't about theProcess()function (I'm going to change it later). Left to do:It would also be nice to include the ability to verify hashes with Redump.org or a similar database (https://bugs.dolphin-emu.org/issues/10867), but that's complex enough that I don't want to do it in this PR.