Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ControllerInterface: Rename full surface analog inputs. #7923

Merged
merged 1 commit into from Apr 13, 2019

Conversation

4 participants
@jordan-woyak
Copy link
Member

commented Mar 23, 2019

Here's a collection of screenshots from users that couldn't figure out why their sticks were "misaligned".

https://i.imgur.com/TzBTbsf.png
https://i.redd.it/josaz8x7ipk21.jpg
https://pbs.twimg.com/media/D1ZJeaxU0AA1t9B.jpg
https://forums.dolphin-emu.org/attachment.php?aid=17746
https://pbs.twimg.com/media/D3qPb9MXkAUoWrL.png

They've all accidentally mapped a direction of their stick to the "full surface" mapping which is sometimes needed for analog triggers. This is caused by not having the stick centered when clicking the mapping button.

The mistake is too hard to see. "+" vs. "-+" or "-" vs. "+-".

I've renamed full surface analog inputs to be more visually dissimilar from their underlying inputs.
The old naming was of the form, "Axis X-+". The new naming is "Full Axis X+".

I've added the ability for the old names to still function but new mappings will take on the new names.

This should hopefully make future wrong mappings easier to detect by users.

@BhaaLseN

This comment has been minimized.

Copy link
Member

commented Mar 23, 2019

Other than Triggers, what kind of input would use this? Can we just call them "Trigger" instead?

@jordan-woyak

This comment has been minimized.

Copy link
Member Author

commented Mar 23, 2019

@BhaaLseN It's not necessarily a trigger. And sometimes triggers don't use the "full surface". I think if "Trigger X+" showed up when trying to map an analog stick that would lead to different confusion. And if it didn't show up when mapping triggers (which it sometimes wouldn't) then you'd have confusion there as well.

We really don't know the physical input type of an axis which is kinda the whole source of this "problem". This change at least makes it apparent when mixing "full-surface" mappings with typical signed mappings.

@BhaaLseN

This comment has been minimized.

Copy link
Member

commented Mar 24, 2019

I have trouble finding anything about what a "full-surface" ...thing is, or should be (what's even a surface? That feels 2D to me, not like a 1D Trigger/Axis). So I'm a bit wary whether adding the word "Full" would make much of a difference without raising the question "What's the difference between Full Axis and the normal Axis?"

Looking at those screenshots again, maybe we have a different problem here (aside from the fact that the single character difference can easily be overlooked) - namely that people don't recognize which mappings are conflicting with each other. Can we (sensibly) detect and highlight "Axis X+" and "Axis X-+" for example so the user looks at them specifically, while "Axis Y+" and "Axis Y-" are fine?

@jordan-woyak

This comment has been minimized.

Copy link
Member Author

commented Mar 24, 2019

"Axis X+" is half of the axis and "Full Axis X+" is both "halves". I don't know what else to call it. :P

Even if a user doesn't really understand the difference they can at least see that there IS a difference and solve the problem.

I don't think it makes sense to highlight "-+".

  1. The mappings are potentially valid. Comparing the mapping expression against the 3 other directions to detect mis-mappings would be hacky and not foolproof.
  2. I don't think highlighting alone would alert users of the problem. Users can't even reason that a blinking red "calibrate" button means they should calibrate.
@BhaaLseN

This comment has been minimized.

Copy link
Member

commented Mar 24, 2019

It is indeed better than the current single-character difference thats easy to overlook. Since I don't have any better ideas, we should probably just go with it for now...

ControllerInterface: Rename full surface analog inputs to be more vis…
…ually dissimilar from their underlying inputs. e.g. "Full Axis X+".

@jordan-woyak jordan-woyak force-pushed the jordan-woyak:full-surface-rename branch from 6221966 to be897b4 Apr 13, 2019

@Techjar
Copy link
Contributor

left a comment

LGTM, should be enough to at least make the mistake obvious to users.

@JMC47

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2019

I agree that the +- thing is really easy to miss and this at least makes it easier for us to debug, even if it's not immediately obvious to users.

@JMC47 JMC47 merged commit 1cedbd5 into dolphin-emu:master Apr 13, 2019

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details

@jordan-woyak jordan-woyak deleted the jordan-woyak:full-surface-rename branch Apr 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.