Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D3D12: Fix case where perf queries weren't flushed #7953

Merged
merged 3 commits into from Apr 1, 2019

Conversation

1 participant
@stenzek
Copy link
Contributor

commented Apr 1, 2019

No description provided.

@stenzek

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2019

Vulkan also was vulnerable to the second error (submitting with open queries because there wasn't enough descriptors). I've added a note in the base class to remind callers that the draw must immediately follow the EnableQuery() call, and fixed it in Vulkan as well.

@stenzek

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2019

Confirmed fixed by the reporter: #7853 (comment)

@stenzek stenzek merged commit 8e1fb12 into dolphin-emu:master Apr 1, 2019

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details

@stenzek stenzek deleted the stenzek:lazy-d3d12-perf-queries branch Apr 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.