PixelShaderGen: Fix bounding box right/bottom offset #7957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This causes hard crashes in Ultimate Spider-Man, another bounding box game. I will report an issue soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Bounding box right/bottom coordinates are not exclusive (or are exclusive depending on your definition) as was previously thought. This has been verified using a hardware test.
Having this offset causes a regression in the Grubba office peeking cutscene in Paper Mario: TTYD, which is a known to be extremely sensitive to wrong bbox values. I have also tested the removal of the offset against the Puni EFB copy artifacting case, and as expected that does not regress.