Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to usages of std::condition_variable. #7965

Merged
merged 1 commit into from Apr 21, 2019

Conversation

2 participants
@jordan-woyak
Copy link
Member

jordan-woyak commented Apr 6, 2019

AlsaSoundStream's condition variable usage did not hold the relevant mutex when notifying the worker thread. This had the unlikely potential to deadlock.

Immediately lock and unlock the mutex in Event to prevent the signaled thread from waiting on the mutex to be released. Unmeasurable performance increase, maybe?

RenderBase.h included <condition_variable> for no reason.

@stenzek stenzek merged commit 44d5a71 into dolphin-emu:master Apr 21, 2019

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details

@jordan-woyak jordan-woyak deleted the jordan-woyak:condvar-fixes branch Apr 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.