Windows: Use a shared precompiled header for dolphin code under Source/ #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Xaudio2 and Xinput still work, as @shuffle2 requested I test. |
|
LGTM |
|
Zc:inline is documented here http://msdn.microsoft.com/en-us/library/dn642448.aspx and seems to slice off a few seconds. Not much for us as we don't spend much time linking to begin with. |
|
LGTM |
|
@dolphin-emu-bot rebuild |
shuffle2
added a commit
that referenced
this pull request
Aug 16, 2014
Windows: Use a shared precompiled header for dolphin code under Source/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR makes Windows builds on msbuild use pch.h for all code under the Source directory.
wxWidgets already was using it's own PCH, and continues to.
Other external code being built wasn't using PCH, and still doesn't.
Cuts build time by 20-50%.
Open questions:
Why does the old syntax for build dependencies need to be used in the sln? ProjectReference in msbuild should be all that's needed.