Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Cubeb as default on Windows #7972

Open
wants to merge 2 commits into
base: master
from

Conversation

2 participants
@Miksel12
Copy link

Miksel12 commented Apr 8, 2019

Cubeb and Xaudio2 are identical in features while Cubeb has lower latency and is actively being worked on.
I personally think Xaudio2 can be removed from the project but this change at least makes sure that new users use the better audio backend by default.

Miksel12 added some commits Apr 8, 2019

Set Cubeb as default on Windows
Cubeb and Xaudio2 are identical in features while Cubeb has lower latency and is still actively being worked on.
@stenzek
Copy link
Contributor

stenzek left a comment

Could you please rebase this on master and remove the merge commit?

@@ -92,7 +92,7 @@ std::string GetDefaultSoundBackend()
#elif defined __APPLE__

This comment has been minimized.

Copy link
@stenzek

stenzek Apr 21, 2019

Contributor

This could be simplified to

#elif defined(__APPLE__) || defined(_WIN32)
  backend = BACKEND_CUBEB;
#endif
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.