Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't enforce that a memory card has to have a .raw or .gcp file extension. #7975

Open
wants to merge 2 commits into
base: master
from

Conversation

4 participants
@AdmiralCurtiss
Copy link
Contributor

AdmiralCurtiss commented Apr 10, 2019

Sorta implements this feature request: https://forums.dolphin-emu.org/Thread-support-bin-extension-for-gc-memory-card-manager

I've not actually added *.bin as a suggested filetype as that's very generic, but if someone wants to open a bin as a Memory Card, why not let them?

@JMC47

This comment has been minimized.

Copy link
Contributor

JMC47 commented Apr 10, 2019

lgtm

@@ -50,15 +50,6 @@ GCMemcard::GCMemcard(const std::string& filename, bool forceCreation, bool shift
}
else
{
// This function can be removed once more about hdr is known and we can check for a valid header

This comment has been minimized.

Copy link
@Techjar

Techjar Apr 11, 2019

Contributor

Shouldn't we actually implement this valid header check?

This comment has been minimized.

Copy link
@AdmiralCurtiss

AdmiralCurtiss Apr 11, 2019

Author Contributor

I suppose so. In this PR or in a separate one?

This comment has been minimized.

Copy link
@BhaaLseN

BhaaLseN Apr 11, 2019

Member

I'd do it here (by replacing this filter) if we have an easily usable method for it (or something that can easily be turned into such a method); otherwise in a follow-up PR (to make reviews easier)

This comment has been minimized.

Copy link
@AdmiralCurtiss

AdmiralCurtiss Apr 11, 2019

Author Contributor

Apart from the Dir/BAT checksum calculations that are right below this block and the rudimentary filesize checks I'm not seeing any existing code that checks for card validity.

This comment has been minimized.

Copy link
@BhaaLseN

BhaaLseN Apr 11, 2019

Member

Different PR it is then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.