Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: Don't needlessly flush register state in merged integer+branch code #798

Merged
merged 1 commit into from Aug 14, 2014

Conversation

FioraAeterna
Copy link
Contributor

The actual branch code doesn't flush the register state, so it doesn't make
much sense for the merged optimization to do so either.

Not tested for performance yet, but it surely can't be /slower/.

@FioraAeterna
Copy link
Contributor Author

Also if anyone knows why it was done this way (or if there's a good reason) I'd love to know; I encountered this while trying to write merged float cmp/branch code and found it was slower than master when flushing the register cache, and then noticed that the integer merged branch code was doing the same

The actual branch code doesn't flush the register state, so it doesn't make
much sense for the merged optimization to do so either.
@Sonicadvance1
Copy link
Contributor

Right. I missed these with the whole conditional branch + not dumping register cache state a few months ago.

Thanks for catching these!

Sonicadvance1 added a commit that referenced this pull request Aug 14, 2014
JIT: Don't needlessly flush register state in merged integer+branch code
@Sonicadvance1 Sonicadvance1 merged commit 64697ab into dolphin-emu:master Aug 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants