Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger/Memory: Add support for address spaces #7980

Open
wants to merge 1 commit into
base: master
from

Conversation

4 participants
@booto
Copy link
Contributor

booto commented Apr 11, 2019

Different address spaces can be chosen in the memory view panel.

  • Effective (or virtual): Probably the view people mostly want. Address
    translation goes through MMU.
  • Auxiliary: ARAM address space. Does not display anything in Wii mode.
  • Physical: Physical address space. Only supports mem1 and mem2 (wii
    mode) so far.

@booto booto force-pushed the booto:memview-wtf branch 3 times, most recently from 0470e24 to f760290 Apr 11, 2019

@booto booto force-pushed the booto:memview-wtf branch from f760290 to 8278fd0 Apr 12, 2019

@spycrab
Copy link
Contributor

spycrab left a comment

mostly LGTM, untested.

@@ -26,6 +31,99 @@
// 120; i.e., 120 units * 1/8 = 15 degrees." (http://doc.qt.io/qt-5/qwheelevent.html#angleDelta)
constexpr double SCROLL_FRACTION_DEGREES = 15.;

namespace

This comment has been minimized.

Copy link
@spycrab

spycrab Apr 13, 2019

Contributor

That's a lot of code that is not bound to Qt. Maybe move this to UICommon?

This comment has been minimized.

Copy link
@booto

booto Apr 13, 2019

Author Contributor

Yep, it makes sense to move it all out into something non-qt related. Going to move to Core/HW, as there's no UI-specific stuff in here either.

This comment has been minimized.

Copy link
@booto

booto Apr 14, 2019

Author Contributor

Moving stuff has highlighted some problems, leaving other things (that assumed everything would be operating on mem1) in a pretty bad state - going to rework.

@booto booto force-pushed the booto:memview-wtf branch 3 times, most recently from 956bc0d to 5c10b35 Apr 14, 2019

Debugger/Memory: Add support for address spaces
Different address spaces can be chosen in the memory view panel.
 * Effective (or virtual): Probably the view people mostly want. Address
   translation goes through MMU.
 * Auxiliary: ARAM address space. Does not display anything in Wii mode.
 * Physical: Physical address space. Only supports mem1 and mem2 (wii
   mode) so far.

@booto booto force-pushed the booto:memview-wtf branch from 5c10b35 to f1045cc Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.