Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpreter: Fix psq_l with QUANTIZE_FLOAT. #7981

Merged
merged 1 commit into from Apr 16, 2019

Conversation

3 participants
@degasus
Copy link
Member

degasus commented Apr 11, 2019

psq_l with QUANTIZE_FLOAT does not use the FPU, so it does not trim the precision of the u32 input data. We already have the helper ConvertToDouble for floating point u32->u64 convertion used in lfs, so let's use it here as well.

compiles fine, but highly untested, might kill kittens

@degasus degasus requested a review from Tilka Apr 11, 2019

Interpreter: Fix psq_l with QUANTIZE_FLOAT.
psq_l with QUANTIZE_FLOAT does not use the FPU, so it does not trim the precision of the u32 input data.
We already have the helper ConvertToDouble for floating point u32->u64 convertion used in lfs, so let's use it here as well.

@degasus degasus force-pushed the degasus:interpreter_psq_l branch from 43454dc to 399768c Apr 11, 2019

@MerryMage
Copy link
Member

MerryMage left a comment

lgtm

@degasus degasus merged commit f1620f2 into dolphin-emu:master Apr 16, 2019

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
@shuffle2

This comment has been minimized.

Copy link
Contributor

shuffle2 commented Apr 16, 2019

hm, it would be nice to test changes like this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.