Debugger: make "PPC to x86" open JIT window #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The button just silently did nothing if the window wasn't open, with no hint as to how to make it work.
Sonicadvance1
added a commit
that referenced
this pull request
Aug 14, 2014
Debugger: make "PPC to x86" open JIT window
|
Where is this func actually called? This should actually be handled through event propagation if it's called from the DolphinWX code. If it's called from the JIT core (ew, I should refactor it in that case) then, ¯_(ツ)_/¯, oh well. |
|
Called from the wx debugger interface. |
|
Still a bit crap. This is all the dirty code from original open sourcing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The button just silently did nothing if the window wasn't open, with no hint
as to how to make it work.