Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional cleanup/fixes from VideoCommon merge #8000

merged 7 commits into from Apr 22, 2019


2 participants
Copy link

stenzek commented Apr 15, 2019

Some more cleanup that didn't make it into the main videocommon PR. Shouldn't break anything.. (famous last words)

We need to improve our GL error reporting for link failures, but this was broken previously anyway. The second commit removes the dependency on <windows.h> for VideoCommon.h, which was kinda silly in the first place.


This comment has been minimized.

Copy link

shuffle2 commented Apr 16, 2019

fwiw, Windows.h is in pch, so the include didn't do anything either way.

@stenzek stenzek force-pushed the stenzek:more-videocommon-cleanup branch 2 times, most recently from 8365d4d to bcb1deb Apr 20, 2019

@stenzek stenzek changed the title Additional small cleanup from VideoCommon merge Additional cleanup/fixes from VideoCommon merge Apr 20, 2019

@stenzek stenzek force-pushed the stenzek:more-videocommon-cleanup branch 2 times, most recently from 4446f68 to 34ffbf2 Apr 20, 2019

stenzek added some commits Mar 5, 2019

OGL: Fix binding error on shutdown
This was occurring if the imgui vertex format was bound on shutdown,
which is destroyed before the vertex buffers
OGL: Store shader source in OGLShader
So it can be dumped with info log when linking fails.
OGL: Set shared context state up to match main context
Has a better chance of avoiding recompiling if so.

@stenzek stenzek force-pushed the stenzek:more-videocommon-cleanup branch from 34ffbf2 to 356ebdf Apr 21, 2019

@stenzek stenzek merged commit 59c0e51 into dolphin-emu:master Apr 22, 2019

10 checks passed

default Very basic checks passed, handed off to Buildbot.
lint Build succeeded on builder lint
pr-android Build succeeded on builder pr-android
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
pr-deb-x64 Build succeeded on builder pr-deb-x64
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
pr-osx-x64 Build succeeded on builder pr-osx-x64
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
pr-win-x64 Build succeeded on builder pr-win-x64

@stenzek stenzek deleted the stenzek:more-videocommon-cleanup branch Apr 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.