Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix and reorder lwz Jit idle skip #8003

Open
wants to merge 1 commit into
base: master
from

Conversation

2 participants
@zlice
Copy link

commented Apr 16, 2019

https://bugs.dolphin-emu.org/issues/10129
Probably conflicts with #7287 by @degasus

This fixes the manhole opener for the back of the train in RE0 (Resident Evil 0)
I'm not familiar enough with the code to say why, my only guess is that the call to WriteExceptionExit() clobbers a register somewhere.

This DOES NOT however fix games like Need For Speed: Hot Pursuit 2. The OPCD == 32 (LWZ) causes the game to perform very poorly. Commenting it out (like in degasus' PR) fixes this problem and seems to have no effect on any of the games I have tested (see bug link).

Don't recommend to merge this, just bring attention.

@MerryMage

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

The reason it's broken is because WriteExceptionExit does not flush anything (so any cached register state is lost).

See also #7630, which fixes this in a different way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.