Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoCommon: Add imgui-based graphics settings window #8010

Open
wants to merge 3 commits into
base: master
from

Conversation

5 participants
@stenzek
Copy link
Contributor

commented Apr 19, 2019

This PR adds a graphics configuration window which can be used in-game. The main motivation is so that graphics options can be changed while the game is running on android, but more relevant to myself, nogui builds.

Note that the options won't be tweakable on android yet, as we haven't hooked up imgui input to touch events. This will come later.

imgui

Options overriden by gameini/netplay/etc will be shown in red (we can't do bold in imgui, since it's a bitmap font).
image

@JosJuice

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2019

As mentioned in PR #7959, please don't use GetStringT with imgui before we have a font with better language support.

@stenzek

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2019

@JosJuice I was hoping to address the font issue as well as the input issue prior to merging. If that doesn't happen, I'll replace it with a placeholder in the interim.

@8times9

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2019

Is there any reason the option descriptions aren’t visible?

@iwubcode

This comment has been minimized.

Copy link
Contributor

commented Apr 20, 2019

First of all - that looks really good @stenzek ! I ran into this with the #7930 where I was concerned about the overhead to change options / add new options if you have to now do it in two places. That's why for that, I opted to only pick up a handful of the settings (IR and Ansio atm) which gives it a more PC style experience, leaving the full system still tweakable in Qt. Are you worried about the duplication at all?

Since I was aiming for a more couch-style solution so I didn't want comboboxes (even if they were interact-able with a controller) but they look nice here.

Nice work!

@stenzek

This comment has been minimized.

Copy link
Contributor Author

commented Apr 20, 2019

@8times9 It would be trivial to implement the descriptions by tooltip, but given this is targeted more towards Android, the mouse-over technique doesn't really map over. I'm open to other suggestions.

@iwubcode I don't see why the two can't complement each other. As I said above, the settings window itself is more targeted towards platforms which don't have the Qt Frontend.

@JMC47

This comment has been minimized.

Copy link
Contributor

commented May 18, 2019

Is there anything (aside from merge conflicts?) preventing this from being merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.