Removed warnings by explicitly casting to u8 for controllers
#803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there anything preventing this from being merged? |
|
Oh sorry about that. This looks fine. |
|
It's no problem. |
Sonicadvance1
added a commit
that referenced
this pull request
Aug 18, 2014
Removed warnings by explicitly casting to `u8` for controllers
|
This change causes the Android joysticks to not register anything outside of the top right corner, on-screen or mapped. This does not affect the desktop builds. Didn't really have time to do anything about it, just reporting it ATM. |
| pad->stickX = GCPadStatus::MAIN_STICK_CENTER_X + (x * GCPadStatus::MAIN_STICK_RADIUS); | ||
| pad->stickY = GCPadStatus::MAIN_STICK_CENTER_Y + (y * GCPadStatus::MAIN_STICK_RADIUS); | ||
| pad->stickX = GCPadStatus::MAIN_STICK_CENTER_X + (u8)(x * GCPadStatus::MAIN_STICK_RADIUS); | ||
| pad->stickY = GCPadStatus::MAIN_STICK_CENTER_Y + (u8)(y * GCPadStatus::MAIN_STICK_RADIUS); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
I think this would be a great candidate for C++ casts...it would remove all ambiguity from what is being casted. |
|
Agreed |
|
Alright, I've submitted a PR that should fix these bugs. Apologies for introducing them, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.