Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DolphinQt: Fix "Default" and "Clear" buttons not updating the displayed extension. #8042

Merged
merged 1 commit into from Apr 29, 2019

Conversation

@jordan-woyak
Copy link
Member

jordan-woyak commented Apr 27, 2019

Because the wrong signal was connected an extension change was not shown in the UI on "Default" or "Clear" press.

I eliminated the redundant enum of emulated wii remote extensions types.

Extension names should now be translated.

I also changed some explicit blockSignals calls to use QSignalBlocker.

@Helios747

This comment has been minimized.

Copy link
Contributor

Helios747 commented Apr 28, 2019

code LGTM. untested.

@JMC47 JMC47 merged commit 360f2b4 into dolphin-emu:master Apr 29, 2019
10 checks passed
10 checks passed
default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
@jordan-woyak jordan-woyak deleted the jordan-woyak:mapping-ui-clear-fix branch May 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.