Externals: update Bochs to newer version #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should resolve the disassembler not handling all the opcodes Dolphin generates.
|
@lioncash you've been doing some work on disassemblers recently, care to review this? |
|
Admittedly this is pretty ugly, I basically copy-pasted in the newer code, changed the cmakelists/vcproj, and stuck the missing defines into config.h. |
|
@fiora how is that ugly? That's all that should be done. On Fri, Aug 15, 2014 at 12:51 AM, Fiora notifications@github.com wrote:
|
|
Yeah, seems fine to me. |
lioncash
added a commit
that referenced
this pull request
Aug 15, 2014
Externals: update Bochs to newer version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Should resolve the disassembler not handling all the opcodes Dolphin generates.
Before someone dives in to say "but you should use a real debugger!", this is my pre-emptive pouty face.