Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] CMake Quality of Life improvements #8101

merged 6 commits into from May 16, 2019


5 participants
Copy link

commented May 15, 2019

Should work with Visual Studio 2019 (non-Preview) now.

Show resolved Hide resolved CMakeSettings.json Outdated

@spycrab spycrab force-pushed the spycrab:cmake_qol branch from 17eb84c to 481b7cd May 15, 2019


This comment has been minimized.

Copy link

commented May 16, 2019

Seems fine to me. I'll do whatever I have to in order to build.

@spycrab spycrab merged commit dce056b into dolphin-emu:master May 16, 2019

10 checks passed

default Very basic checks passed, handed off to Buildbot.
lint Build succeeded on builder lint
pr-android Build succeeded on builder pr-android
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
pr-deb-x64 Build succeeded on builder pr-deb-x64
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
pr-osx-x64 Build succeeded on builder pr-osx-x64
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
pr-win-x64 Build succeeded on builder pr-win-x64

@spycrab spycrab deleted the spycrab:cmake_qol branch May 16, 2019

@@ -3,10 +3,10 @@
"name": "Release",
"configurationType": "Release",
"generator": "Visual Studio 16 2019 Win64",
"generator": "Ninja",

This comment has been minimized.

Copy link

lioncash May 19, 2019


I'd be surprised if the previous Visual Studio specifier even worked. Since VS 2019, in CMake, generation needs to be specified like:

cmake -G "Visual Studio 16 2019" -A x64

Win64 isn't a thing anymore for the generator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.