Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt/Debugger CodeWidget navigation unification #8102

Open
wants to merge 1 commit into
base: master
from

Conversation

1 participant
@dreamsyntax
Copy link
Contributor

commented May 16, 2019

Summary:

Changed itemSelectionChanged and itemClicked signal to itemPressed in CodeWidget.
Holding mouse down and moving will only travel up/down the stack one time.
This fixes the common occurrence of unintentionally traveling deeper down the stack or higher up the callstack than intended.


Details:

Behavior before:
symbols
Clicking (and holding) item A, then moving mouse down to item B, then moving back to item A results in viewing item A.

callstack/calls/callers
Holding mouse down and moving mouse would result in continually triggering the OnSelectFunctionX, making it possible for debuggers to accidentally go up/down the callstack further than intended.

Behavior after:
symbols
Immediately jumps to item A regardless of hold.

callstack/calls/callers
Holding mouse down and moving will only travel up/down the stack one time. The issue of traveling too far will not occur.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.