Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
UICommon/ResourcePack: Minor cleanup #8127
Same behavior, only it doesn't unnecessarily store a pointer in the executable. While we're at it, make it constexpr and move it into the namespace.
A few cases duplicate the string patch creation, which is kind of wasteful. We can just construct the string once.
Makes it way harder to introduce resource leaks, and plugs the existing resource leaks in the constructor and Install() where the file wouldn't be closed in some error cases.
…any contiguous container This allows the same code to be used to read into a std::string, which allows for eliminating the vector->string transfer when reading the manifest file. A ContiguousContainer is a concept that includes std::array, std::string, and std::vector.
leoetlino merged commit
May 27, 2019
10 checks passed
10 checks passed
default Very basic checks passed, handed off to Buildbot.Details
lint Build succeeded on builder lintDetails
pr-android Build succeeded on builder pr-androidDetails
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64Details
pr-deb-x64 Build succeeded on builder pr-deb-x64Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64Details
pr-osx-x64 Build succeeded on builder pr-osx-x64Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64Details
pr-win-x64 Build succeeded on builder pr-win-x64Details
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.