Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code: Rename AVIDump to FrameDump #8128

Merged
merged 1 commit into from Jun 30, 2019

Conversation

4 participants
@altimumdelta
Copy link
Contributor

commented May 28, 2019

Some preparation for the frame dumping improvements could go ahead earlier, to take the weight off the main PR #8121

EDIT: This PR does not depend on any of the other discussions or decisions in the main PR, so it's ready to merge, I could do some minor improvements in the meantime before the larger parts.

@altimumdelta altimumdelta force-pushed the altimumdelta:FrameDumpUpgradePrep1 branch from 6dc00ca to 431dd9c May 28, 2019

@altimumdelta altimumdelta force-pushed the altimumdelta:FrameDumpUpgradePrep1 branch from 431dd9c to cd7773b May 28, 2019

@altimumdelta altimumdelta force-pushed the altimumdelta:FrameDumpUpgradePrep1 branch from cd7773b to fa4722b Jun 2, 2019

@stenzek
Copy link
Contributor

left a comment

Could be worth moving the png dumping into the FrameDump class, but that's a separate change. LGTM otherwise.

@altimumdelta altimumdelta force-pushed the altimumdelta:FrameDumpUpgradePrep1 branch from fa4722b to 66b3d83 Jun 30, 2019

@altimumdelta

This comment has been minimized.

Copy link
Contributor Author

commented Jun 30, 2019

Will try. Lint issues corrected.

@stenzek

This comment has been minimized.

Copy link
Contributor

commented Jun 30, 2019

Lint still isn't happy. The changes which need to be applied can be seen here: https://buildbot.dolphin-emu.org/#/builders/22/builds/5142/steps/2/logs/stdio

@altimumdelta altimumdelta force-pushed the altimumdelta:FrameDumpUpgradePrep1 branch from 66b3d83 to 02eb040 Jun 30, 2019

@altimumdelta

This comment has been minimized.

Copy link
Contributor Author

commented Jun 30, 2019

Oh, somehow forgot about the rest. Didn't know it also trips on extra spaces, but those aren't as obvious in the log output to spot.

@altimumdelta altimumdelta force-pushed the altimumdelta:FrameDumpUpgradePrep1 branch from 02eb040 to 1df655e Jun 30, 2019

@BhaaLseN
Copy link
Member

left a comment

Lint is there to make sure code follows a consistent and uniform style; that includes trailing whitespace. clang-format will take care of that for you, if you're on Linux/macOS; or a Visual Studio plugin if you're on Windows.

@stenzek

This comment has been minimized.

Copy link
Contributor

commented Jun 30, 2019

FWIW, on latest Visual Studio, no need to install a plugin. CTRL+K, CTRL+D "just works" :)

@stenzek stenzek merged commit 0a7395b into dolphin-emu:master Jun 30, 2019

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details

@altimumdelta altimumdelta deleted the altimumdelta:FrameDumpUpgradePrep1 branch Jun 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.