Fixed toolbar's disabled button color. #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| toolBar->AddTool(IDM_STEPOVER, _("Step Over"), m_Bitmaps[Toolbar_StepOver]); | ||
| toolBar->AddTool(IDM_SKIP, _("Skip"), m_Bitmaps[Toolbar_Skip]); | ||
| WxUtils::AddToolbarButton(toolBar, IDM_STEP, _("Step"), m_Bitmaps[Toolbar_Step], "Step into the next instruction"); | ||
| WxUtils::AddToolbarButton(toolBar, IDM_STEPOVER, _("Step Over"), m_Bitmaps[Toolbar_StepOver], "Step over the next instruction"); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Screenshots please. |
|
Here's an imgur album. |
| @@ -75,6 +76,19 @@ wxBitmap _wxGetBitmapFromMemory(const unsigned char* data, int length) | |||
| return(wxBitmap(wxImage(is, wxBITMAP_TYPE_ANY, -1), -1)); | |||
| } | |||
|
|
|||
| wxBitmap CreateDisabledButtonBitmap(wxBitmap original) | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Rebased. |
|
Tested it. LGTM, at least on windows. Though I still don't understand why the text is not antialiased... |
lioncash
added a commit
that referenced
this pull request
Aug 23, 2014
Fixed toolbar's disabled button color.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Before, it would simply desaturate the buttons when they were disabled (which was an issue with the black-and-white buttons). Now it simply lightens it like it should.
A workaround had to be used that explicitly sets the buttons' disabled bitmaps to a lightened version. This happens automagically, though, so there's no need to bundle disabled icons with the themes.
This has been tested on Linux, Windows, and OS X.