Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed warnings by assigning to bool #818

Merged
merged 1 commit into from Aug 16, 2014

Conversation

crozhon
Copy link
Contributor

@crozhon crozhon commented Aug 16, 2014

There's no mention in the style guide of whether the !!value or value != 0 syntax is preferred for casts to bool. I asked around on IRC and value != 0 seems to be preferred.

@RachelBryk
Copy link
Member

LGTM

@lioncash
Copy link
Member

Looks good if you parenthesize the var != 0 conditions.

Thanks for going through the trouble of fixing these warnings though. You make my future workload a little lighter. I appreciate it :)

@crozhon
Copy link
Contributor Author

crozhon commented Aug 16, 2014

Should be all set. And it's no problem. It gives me a chance to get familiar with the code and maybe fix a real issue somewhere down the road.

lioncash added a commit that referenced this pull request Aug 16, 2014
@lioncash lioncash merged commit bc1d905 into dolphin-emu:master Aug 16, 2014
@crozhon crozhon deleted the videocommon_bool_warnings branch August 16, 2014 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants