Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core/Core: Use fmt where applicable #8226

Merged
merged 1 commit into from Aug 9, 2019

Conversation

@lioncash
Copy link
Member

commented Jul 3, 2019

Continues the migration over to using fmt. Given fmt is also compatible with std::string and std::string_view, we can convert some parameters over to std::string_view, such as the message parameter for StopMessage() and the name parameter for an overload of SaveScreenShot()

@BhaaLseN
Copy link
Member

left a comment

Code seems good, untested.

Core/Core: Use fmt where applicable
Continues the migration over to using fmt. Given fmt is also compatible
with std::string and std::string_view, we can convert some parameters
over to std::string_view, such as the message parameter for
StopMessage() and the name parameter for an overload of SaveScreenShot()

@lioncash lioncash force-pushed the lioncash:fmt-core branch from 8713fa3 to 1f98188 Jul 23, 2019

@stenzek stenzek merged commit 5c3e9a3 into dolphin-emu:master Aug 9, 2019

@lioncash lioncash deleted the lioncash:fmt-core branch Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.