Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DolphinQt: Don't update debug widgets when hidden #8231

Merged
merged 1 commit into from Jul 7, 2019

Conversation

3 participants
@JosJuice
Copy link
Contributor

commented Jul 6, 2019

Saves on CPU usage when pausing/unpausing with the debugger disabled. This is especially important when using frame advance rapidly.

DolphinQt: Don't update debug widgets when hidden
Saves on CPU usage when pausing/unpausing with the debugger disabled.
This is especially important when using frame advance rapidly.
@spycrab

spycrab approved these changes Jul 7, 2019

Copy link
Contributor

left a comment

LGTM. Untested though

@JMC47

This comment has been minimized.

Copy link
Contributor

commented Jul 7, 2019

Seems to work fine for me.

@JMC47 JMC47 merged commit 398aa2a into dolphin-emu:master Jul 7, 2019

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details

@JosJuice JosJuice deleted the JosJuice:debugger-hidden branch Jul 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.