Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StringUtil: Use std::string_view more #8233

Merged
merged 2 commits into from Aug 9, 2019

Conversation

@JosJuice
Copy link
Contributor

commented Jul 8, 2019

No description provided.

@JosJuice JosJuice force-pushed the JosJuice:stringutil-string-view branch 2 times, most recently from e4326a4 to 12bce16 Jul 8, 2019

@BhaaLseN
Copy link
Member

left a comment

Looks good I guess; untested.

Source/Core/Common/StringUtil.cpp Outdated Show resolved Hide resolved
@CookiePLMonster
Copy link
Contributor

left a comment

LGTM with a few points to note.

@JosJuice JosJuice force-pushed the JosJuice:stringutil-string-view branch from c33f2d4 to fd82a64 Jul 23, 2019

Source/Core/Common/IniFile.cpp Outdated Show resolved Hide resolved
Source/Core/Common/IniFile.cpp Outdated Show resolved Hide resolved
Source/Core/InputCommon/InputProfile.cpp Show resolved Hide resolved

@JosJuice JosJuice force-pushed the JosJuice:stringutil-string-view branch from fd82a64 to 117a60c Jul 23, 2019

@stenzek stenzek merged commit 48ca2c6 into dolphin-emu:master Aug 9, 2019

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details

@JosJuice JosJuice deleted the JosJuice:stringutil-string-view branch Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.