Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core/HW/AddressSpace: Remove unnecessary inclusion of Core.h #8247

Merged
merged 2 commits into from Jul 16, 2019

Conversation

@lioncash
Copy link
Member

lioncash commented Jul 16, 2019

This is only included to satisfy the use of our type aliases. Given that, we can just include CommonTypes.h, lessening dependencies on core headers.

While we're at it, we can use a forward declaration to move inclusions of AddressSpace.h itself into cpp files where it's needed.

lioncash added 2 commits Jul 16, 2019
This is only included to satisfy the use of our type aliases. Given
that, we can just include CommonTypes.h, lessening dependencies on core
headers.
@booto
booto approved these changes Jul 16, 2019
@stenzek stenzek merged commit 9dd8f82 into dolphin-emu:master Jul 16, 2019
10 checks passed
10 checks passed
default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
@lioncash lioncash deleted the lioncash:core-include branch Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.