Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "not signed by Nintendo" warning when installing WADs #8255

Merged
merged 3 commits into from Aug 21, 2019

Conversation

@JosJuice
Copy link
Contributor

commented Jul 19, 2019

Apparently nobody is using good dumps, meaning that the warning is a nuisance rather than useful information for most people. Especially so for people who don't install WADs permanently.

It is still possible to verify the signature using the Verify tab of the game properties, which matches how Dolphin handles checking the signatures of Wii discs.

@BhaaLseN

This comment has been minimized.

Copy link
Member

commented Jul 20, 2019

Thoughts on just using that nag dialog as "disable signature checks permanently" instead of removing it completely? The option had been there before, and gets rid of the popup.

@JosJuice

This comment has been minimized.

Copy link
Contributor Author

commented Jul 20, 2019

I suppose we could do that, as long as it wouldn't also disable signature checks for NUS downloading. It's just that I'm not sure if there's a point in having yet another user visible setting in Dolphin for something this minor. (I'm assuming we would need to add it to the config window so that you have a way to change it back if you disabled it using the nag dialog and then change your mind.)

JosJuice added some commits Jul 19, 2019

Remove "not signed by Nintendo" warning when installing WADs
Apparently nobody is using good dumps, meaning that the warning
is a nuisance rather than useful information for most people.
Especially so for people who don't install WADs permanently.

It is still possible to verify the signature using the Verify
tab of the game properties, which matches how Dolphin handles
checking the signatures of Wii discs.
Remove the EnableSignatureChecks setting
Since Dolphin can do NUS downloads over plain HTTP, we really don't
want people to be able to silently disable signature verification
indefinitely. Removing the setting shouldn't have any significant
negative impact now that signature verification always is disabled
when installing WAD files.
Force signature verification during system update from disc
Unlike the WADs people put in their game lists, these WADs
should always be correctly signed.

@JosJuice JosJuice force-pushed the JosJuice:remove-unsigned-warning branch from 2acd92e to a8807e7 Jul 21, 2019

@JMC47

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2019

Is there anything blocking this from being merged?

@Helios747 Helios747 merged commit 2a95227 into dolphin-emu:master Aug 21, 2019

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
@Helios747

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

me making a merge party and not giving a fuck, mainly

@JosJuice JosJuice deleted the JosJuice:remove-unsigned-warning branch Aug 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.