Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upNever set disc as active title when launching channel with same ID #8256
Conversation
|
Logic LGTM, but maybe use an enum (class) instead of a bool for readability? |
JosJuice
force-pushed the
JosJuice:setrunninggamemetadata-channel-disc
branch
from
f6d6e61
to
2fda104
This comment has been minimized.
This comment has been minimized.
|
It now uses the |
This comment has been minimized.
This comment has been minimized.
|
(The "WiiWAD" name bothers me a bit, as installed titles aren't really WADs, but I can't think of a better name...) |
leoetlino
merged commit 29ba53f
into
dolphin-emu:master
10 checks passed
10 checks passed
This comment was marked as off-topic.
This comment was marked as off-topic.
Beginningah
commented
Jul 23, 2019
|
Not working in nexus player |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
JosJuice commentedJul 20, 2019
https://bugs.dolphin-emu.org/issues/11804