Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never set disc as active title when launching channel with same ID #8256

Merged

Conversation

@JosJuice
Copy link
Contributor

JosJuice commented Jul 20, 2019

Copy link
Member

leoetlino left a comment

Logic LGTM, but maybe use an enum (class) instead of a bool for readability?

@JosJuice JosJuice force-pushed the JosJuice:setrunninggamemetadata-channel-disc branch from f6d6e61 to 2fda104 Jul 21, 2019
@JosJuice

This comment has been minimized.

Copy link
Contributor Author

JosJuice commented Jul 21, 2019

It now uses the DiscIO::Platform enum.

@leoetlino

This comment has been minimized.

Copy link
Member

leoetlino commented Jul 23, 2019

(The "WiiWAD" name bothers me a bit, as installed titles aren't really WADs, but I can't think of a better name...)

@leoetlino leoetlino merged commit 29ba53f into dolphin-emu:master Jul 23, 2019
10 checks passed
10 checks passed
default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
@JosJuice JosJuice deleted the JosJuice:setrunninggamemetadata-channel-disc branch Jul 23, 2019
@Beginningah

This comment was marked as off-topic.

Copy link

Beginningah commented Jul 23, 2019

Not working in nexus player
Wants 32bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.