Catch broken configurations inside of the Post Processing shaders. #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| case ConfigurationOption::OptionType::OPTION_INTEGER: | ||
| { | ||
| // Make sure our vectors are the same sizes | ||
| if (!(option.second.m_integer_values.size() == option.second.m_integer_min_values.size() && |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This catches most instances of configuration failures that can happen in a post processing shader. Gives a user a helpful error message that lets them know what they have failed to set up correctly
| @@ -47,11 +48,132 @@ std::string PostProcessingShaderConfiguration::LoadShader(std::string shader) | |||
| } | |||
|
|
|||
| LoadOptions(code); | |||
|
|
|||
| std::string error = VerifyOptions(m_options); | |||
| if (error.size()) | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@Sonicadvance1: This comment grants you the permission to merge this pull request whenever you think it is ready. After addressing the remaining comments, click this link to merge. Other than that, LGTM. @dolphin-emu-bot allowmerge |
dolphin-emu-bot
added a commit
that referenced
this pull request
Aug 25, 2014
Catch broken configurations inside of the Post Processing shaders.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This catches most instances of configuration failures that can happen in a post processing shader.
Gives a user a helpful error message that lets them know what they have failed to set up correctly