Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DolphinQt: Refactor render widget initialization #8281

Open
wants to merge 2 commits into
base: master
from

Conversation

@stenzek
Copy link
Contributor

commented Aug 2, 2019

Changes the show/hide to always use new widgets, rather than reparenting and such. Hopefully will improve stability on platforms like Wayland. The added bonus is you can switch to/from the main window while emulation is running.

Marked WIP because there's still some issues with input not being switched over correctly.

@stenzek stenzek added the WIP label Aug 2, 2019

void MainWindow::ConnectHost()
{
connect(Host::GetInstance(), &Host::UpdateProgressDialog, this,
&MainWindow::OnUpdateProgressDialog);
connect(Host::GetInstance(), &Host::RequestStop, this, &MainWindow::RequestStop);
connect(Host::GetInstance(), &Host::UpdateRenderWidget, this,

This comment has been minimized.

Copy link
@CookiePLMonster

CookiePLMonster Aug 2, 2019

Contributor

No need to pass this here.

This comment has been minimized.

Copy link
@stenzek

stenzek Aug 2, 2019

Author Contributor

IIRC I had to pass a context parameter to be able to use Qt::QueuedConnection.

This comment has been minimized.

Copy link
@CookiePLMonster

CookiePLMonster Aug 2, 2019

Contributor

Oh right, Qt::QueuedConnection is outside the lambda! nvm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.