Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SI: Be more careful with polling controllers #8282

Open
wants to merge 1 commit into
base: master
from

Conversation

@booto
Copy link
Contributor

commented Aug 2, 2019

Return errors if no device is connected (e.g. unplugged controller from
gcadapter). Only poll channels if polling is enabled for that channel.

Generating builds for testing.

SI: Be more careful with polling controllers
Return errors if no device is connected (e.g. unplugged controller from
gcadapter). Only poll channels if polling is enabled for that channel.

@booto booto force-pushed the booto:gcadapter-disco branch from 6aa20dc to b3264af Aug 2, 2019

@@ -72,7 +72,10 @@ int CSIDevice_GCAdapter::RunBuffer(u8* buffer, int length)
bool CSIDevice_GCAdapter::GetData(u32& hi, u32& low)
{
CSIDevice_GCController::GetData(hi, low);

This comment has been minimized.

Copy link
@BhaaLseN

BhaaLseN Aug 2, 2019

Member

Feels a bit weird that this is called before the DeviceConnected check...should this be here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.