Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use valid IR calibration data #8292

Open
wants to merge 1 commit into
base: master
from

Conversation

@Pokechu22
Copy link
Contributor

commented Aug 5, 2019

Previously, IR calibration data with an invalid checksum was used, because the calibration produced a strange offset. I've replaced it with calibration data that encodes the same values as the data Nintendo falls back to when the checksum is bad.

I've also updated the documentation on wiibrew, though I'm not completely happy with the naming and I'm still not 100% sure what these values mean — but I know enough to at least replace it with the defaults.

It's worth noting that dolphin doesn't use the same value for acceleration as Nintendo defaults to — but it's probably not worth changing that as that would cause issues with TAS and such. Since IR already behaved as if it were the default, it's fine to change this one.

Use valid IR calibration data
Previously, IR calibration data with an invalid checksum was used, because the calibration produced a strange offset.  I've replaced it with calibration data that encodes the same values as the data Nintendo falls back to when the checksum is bad.

@Pokechu22 Pokechu22 force-pushed the Pokechu22:ir-calibration branch from 8abd97c to 7c892c0 Aug 5, 2019

@jordan-woyak

This comment has been minimized.

Copy link
Member

commented Aug 11, 2019

@dolphin-emu-bot rebuild.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.