Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt/GCMemcardManager: Fix icon animations displaying incorrectly. #8304

Open
wants to merge 2 commits into
base: master
from

Conversation

@AdmiralCurtiss
Copy link
Contributor

commented Aug 8, 2019

The previous code had some odd assumptions that caused it to only show, at max, the first three frames of each animation. It also didn't handle the animation speed or the ping-pong frame order correctly. This should all be fixed with this.

The performance of this I mentioned in IRC is marginally improved by this due to the timer running less often, but it's still pretty poor; further investigation into that is necessary.

@AdmiralCurtiss

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2019

For reference, here's a memory card with various animated icons: animations.zip

@AdmiralCurtiss AdmiralCurtiss force-pushed the AdmiralCurtiss:memcard-manager-icon-fix branch from f371d52 to 820460d Aug 8, 2019

@AdmiralCurtiss AdmiralCurtiss force-pushed the AdmiralCurtiss:memcard-manager-icon-fix branch from 820460d to ecaf6f6 Aug 8, 2019

Source/Core/DolphinQt/GCMemcardManager.cpp Outdated Show resolved Hide resolved
Source/Core/DolphinQt/GCMemcardManager.cpp Outdated Show resolved Hide resolved
Source/Core/DolphinQt/GCMemcardManager.h Outdated Show resolved Hide resolved
Source/Core/DolphinQt/GCMemcardManager.cpp Outdated Show resolved Hide resolved

@AdmiralCurtiss AdmiralCurtiss force-pushed the AdmiralCurtiss:memcard-manager-icon-fix branch from ecaf6f6 to 74bb14a Aug 9, 2019

@AdmiralCurtiss

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

This is good to go from my side, by the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.