Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VolumeVerifier: Allocate QProgressDialog on stack #8306

Merged
merged 1 commit into from Aug 9, 2019

Conversation

@JosJuice
Copy link
Contributor

JosJuice commented Aug 9, 2019

No reason to have it on the heap.

This also lets us skip calling reset, since the dialog closes when the QProgressDialog object goes out of scope.

No reason to have it on the heap.

This also lets us skip calling reset, since the dialog closes
when the QProgressDialog object goes out of scope.
@JosJuice JosJuice force-pushed the JosJuice:volumeverifier-dialog branch from b38ca47 to cd02ca1 Aug 9, 2019
@stenzek
stenzek approved these changes Aug 9, 2019
Copy link
Contributor

stenzek left a comment

LGTM

@stenzek stenzek merged commit 7c1ca1f into dolphin-emu:master Aug 9, 2019
10 checks passed
10 checks passed
default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
@JosJuice JosJuice deleted the JosJuice:volumeverifier-dialog branch Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.