Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement Cheat Search. #8311

Open
wants to merge 5 commits into
base: master
from

Conversation

@AdmiralCurtiss
Copy link
Contributor

commented Aug 13, 2019

Reimplements the Cheat Search functionality in Core for doing the actual memory reading and comparing grunt work, moving it out of the GUI code in Qt/CheatsManager. There's still some functionality remaining in the Qt code (AR code creation, value freezing), but the basic memory searching functionality should now even be theoretically usable from Core.

Merge note: This includes the commits from #8310.

Fixes https://bugs.dolphin-emu.org/issues/11434 by giving explicit 'unknown value' and 'last value' search options.

AdmiralCurtiss added some commits Aug 12, 2019

@AdmiralCurtiss AdmiralCurtiss force-pushed the AdmiralCurtiss:cheat-search-reimpl branch from d69c049 to 2472a09 Aug 13, 2019

Source/Core/Core/CheatSearch.h Show resolved Hide resolved
Source/Core/Core/CheatSearch.cpp Outdated Show resolved Hide resolved
Source/Core/DolphinQt/CheatsManager.cpp Outdated Show resolved Hide resolved
Source/Core/DolphinQt/CheatsManager.cpp Outdated Show resolved Hide resolved

@AdmiralCurtiss AdmiralCurtiss force-pushed the AdmiralCurtiss:cheat-search-reimpl branch from 2472a09 to d6c8e19 Aug 13, 2019

Source/Core/Core/CheatSearch.cpp Outdated Show resolved Hide resolved
Source/Core/Core/CheatSearch.cpp Outdated Show resolved Hide resolved

@AdmiralCurtiss AdmiralCurtiss force-pushed the AdmiralCurtiss:cheat-search-reimpl branch from d6c8e19 to 1d27c99 Aug 13, 2019

@AdmiralCurtiss AdmiralCurtiss force-pushed the AdmiralCurtiss:cheat-search-reimpl branch from 1d27c99 to 4552430 Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.