Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable adapter combo only if adapters are supported by current backend #8324

Merged
merged 1 commit into from Sep 28, 2019

Conversation

@CookiePLMonster
Copy link
Contributor

CookiePLMonster commented Aug 20, 2019

GeneralWidget::OnEmulationStateChanged enabled/disabled the Adapter combo regardless whether the current backend actually supports it or not.

…upported by current backend
@CookiePLMonster

This comment has been minimized.

Copy link
Contributor Author

CookiePLMonster commented Aug 20, 2019

Idea how to engineer this better: either subclass this Qt class to overload setEnabled to check for adapters implicitly, or (if possible) install an event filter on EnabledChange.

Copy link
Member

jordan-woyak left a comment

Looks fine to me. Untested.

@JosJuice JosJuice merged commit 06ab51b into dolphin-emu:master Sep 28, 2019
10 checks passed
10 checks passed
default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
@CookiePLMonster CookiePLMonster deleted the CookiePLMonster:adapter-combo-fix branch Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.