Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upEnable adapter combo only if adapters are supported by current backend #8324
Conversation
…upported by current backend
This comment has been minimized.
This comment has been minimized.
|
Idea how to engineer this better: either subclass this Qt class to overload |
|
Looks fine to me. Untested. |
JosJuice
merged commit 06ab51b
into
dolphin-emu:master
10 checks passed
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
CookiePLMonster commentedAug 20, 2019
GeneralWidget::OnEmulationStateChangedenabled/disabled the Adapter combo regardless whether the current backend actually supports it or not.