misc improvements for msvc build. -Werror for msvc! #833
+516
−514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strictStrings is not supported by debug libraries, and indeed breaks the build. Drop wbemidl.h (incompatible with strictStrings) dependency by using SDL-style search for XInput GUIDs.
|
Same changes, but rewrote history to make it easier to review / look nicer. |
… except for wxWidgets, where all warnings are fixed. Note warnings may still be generated by code in Externals if it is included into warning-enabled code (this is the case for libusb). Also, quiet an intellisense warning in wxWidgets caused by using __w64 for an inapplicable type.
Note: vs14 will support empty macro parameter as used by MMIO.
Also, bring WiiSaveCrypted closer to modern dolphin coding style.
|
Looks good to me. |
shuffle2
added a commit
that referenced
this pull request
Aug 20, 2014
misc improvements for msvc build. -Werror for msvc!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The overall reason for these changes are to allow for treating compiler warnings as errors (we are already treating lib and linker warnings as errors) on msvc.
Other things included:
Improves code style in some areas which had to be touched to fix warnings.
Enables strictStrings standards conformance.