VolumeVerifier: Add Redump.org integration #8330
Conversation
JosJuice
force-pushed
the
redump-integration
branch
from
13b8e1b
to
e3bd475
Compare
|
I've fixed the caching now. |
JosJuice
force-pushed
the
redump-integration
branch
from
e3bd475
to
d1a33ce
Compare
| std::future<std::vector<PotentialMatch>> m_future; | ||
| Result m_result; | ||
|
|
||
| static DownloadState m_gc_download_state; |
There was a problem hiding this comment.
These can be static inline to avoid the need to redefine them in the cpp file.
There was a problem hiding this comment.
I'm getting build errors on non-Windows now. Can this be resolved without removing the inline?
There was a problem hiding this comment.
I've reverted the inline change for now.
JosJuice
force-pushed
the
redump-integration
branch
from
d1a33ce
to
faf1a03
Compare
JosJuice
force-pushed
the
redump-integration
branch
from
faf1a03
to
b65291d
Compare
|
Does it work for Wii games too? AFAIK Redump.org doesn't have a public DAT for Wii ISOs... |
|
It currently doesn't work, but the code is written so that it automatically will start working once the datfile becomes public. Thankfully, having a datfile for Wii games is less important than for GameCube games since Wii games have a lot of verification data built in. |
JosJuice
force-pushed
the
redump-integration
branch
from
b65291d
to
87c5e0b
Compare
| return 0; // Error | ||
|
|
||
| return c; | ||
| } |
There was a problem hiding this comment.
It feels a bit complicated to have this, but according to StackOverflow there isn't really a better way.
https://bugs.dolphin-emu.org/issues/10867
The caching behavior is not especially good right now (if you fail to connect it will cache the fail and not retry again until you restart Dolphin...), but other than thatthis should be ready for review.