Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VolumeVerifier: Add Redump.org integration #8330

Open
wants to merge 3 commits into
base: master
from

Conversation

@JosJuice
Copy link
Contributor

commented Aug 24, 2019

https://bugs.dolphin-emu.org/issues/10867

The caching behavior is not especially good right now (if you fail to connect it will cache the fail and not retry again until you restart Dolphin...), but other than that this should be ready for review.

image

@JosJuice JosJuice force-pushed the JosJuice:redump-integration branch from 13b8e1b to e3bd475 Aug 24, 2019

@JosJuice

This comment has been minimized.

Copy link
Contributor Author

commented Aug 24, 2019

I've fixed the caching now.

@JosJuice JosJuice force-pushed the JosJuice:redump-integration branch from e3bd475 to d1a33ce Aug 24, 2019

std::future<std::vector<PotentialMatch>> m_future;
Result m_result;

static DownloadState m_gc_download_state;

This comment has been minimized.

Copy link
@lioncash

lioncash Aug 24, 2019

Member

These can be static inline to avoid the need to redefine them in the cpp file.

This comment has been minimized.

Copy link
@JosJuice

JosJuice Aug 24, 2019

Author Contributor

I'm getting build errors on non-Windows now. Can this be resolved without removing the inline?

This comment has been minimized.

Copy link
@JosJuice

JosJuice Aug 25, 2019

Author Contributor

I've reverted the inline change for now.

@JosJuice JosJuice force-pushed the JosJuice:redump-integration branch from d1a33ce to faf1a03 Aug 24, 2019

@JosJuice JosJuice force-pushed the JosJuice:redump-integration branch from faf1a03 to b65291d Aug 24, 2019

@mbc07

This comment has been minimized.

Copy link
Contributor

commented Aug 24, 2019

Does it work for Wii games too? AFAIK Redump.org doesn't have a public DAT for Wii ISOs...

@JosJuice

This comment has been minimized.

Copy link
Contributor Author

commented Aug 24, 2019

It currently doesn't work, but the code is written so that it automatically will start working once the datfile becomes public. Thankfully, having a datfile for Wii games is less important than for GameCube games since Wii games have a lot of verification data built in.

@JosJuice JosJuice force-pushed the JosJuice:redump-integration branch from b65291d to 87c5e0b Aug 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.