Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSPLLE: Put DSP thread in idle state when it's paused #8332

Open
wants to merge 1 commit into
base: master
from

Conversation

@CookiePLMonster
Copy link
Contributor

commented Aug 25, 2019

Fixes a deadlock when accessing Graphics config immediately after booting up the game when using a LLE DSP.

DSP thread is considered "idle" when it signals s_ppc_event and waits for s_dsp_event, without putting it in this state when m_dsp_thread_mutex is locked it was possible to create a deadlock between a DSP thread, emulation thread and Qt thread.

DSPLLE: Put DSP thread in idle state if it's paused to prevent a dead…
…lock

DSP thread is considered "idle" when it signals s_ppc_event and waits for s_dsp_event,
without putting it in this state when m_dsp_thread_mutex is locked it was possible to
create a deadlock between a DSP thread, emulation thread and Qt thread by accessing
Config menu immediately after booting up the game
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.