Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dolphin version and current video backend to shader compilation logs #8336

Open
wants to merge 1 commit into
base: master
from

Conversation

@Ebola16
Copy link
Member

commented Aug 26, 2019

Implements https://bugs.dolphin-emu.org/issues/9992

This makes it easier to quickly identify what version of Dolphin and video backend produced shader compilation issues.

@BhaaLseN
Copy link
Member

left a comment

I don't know if those files are meant to be loaded into a shader compiler as-is or not (and as such: whether we should make those two new lines a comment in the given language); but the changes themselves seem fine to me. Untested.

@Ebola16

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2019

I've never tried loading the output directly into a shader compiler but if that was the intended use I could add the Dolphin info to the filename instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.