Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SI: Reduce logging. #8339

Merged
merged 1 commit into from Aug 30, 2019

Conversation

@booto
Copy link
Contributor

commented Aug 29, 2019

An earlier SI PR added logging for SI devices that return the incorrect number of bytes for certain commands. It turns out pretty much every SI device in dolphin returns the wrong number of bytes (#8239 mostly fixes this). For the time being, it results in loads of non-actionable log spam for users that should probably be suppressed.

@Ebola16

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

@booto

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2019

Yes, this was the point. The logs are useless for end-users and the issue is dealt with in a separate PR.

@BhaaLseN

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

Should we leave a comment next to it for later?

@booto

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2019

I don't think that's necessary.

@stenzek stenzek merged commit 1bb7fbb into dolphin-emu:master Aug 30, 2019

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.