Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DolphinQt: Don't overwrite >8x IR scale in ini, add maximum internal res option #8340

Open
wants to merge 1 commit into
base: master
from

Conversation

@stenzek
Copy link
Contributor

commented Aug 30, 2019

This adds an ini-only setting under GFX.ini -> [Settings] -> MaxInternalResolution. Setting this will allow the user to select resolutions beyond the default 8x max scale in graphics options.

Also fixes the bug if a user had a >8xIR set, opening the graphics window would overwrite the value, and save it to the ini.

Requested by @MayImilae.

DolphinQt: Don't overwrite >8x IR scale in ini, add maximum internal …
…res option

This adds an ini-only setting under GFX.ini -> [Settings] ->
MaxInternalResolution. Setting this will allow the user to select
resolutions beyond the default 8x max scale in graphics options.
{
m_ir_combo->addItem(tr("Custom"));
m_ir_combo->setCurrentIndex(m_ir_combo->count() - 1);
resolution_options.append(QString::asprintf("%dx Native (%dx%d)", scale,

This comment has been minimized.

Copy link
@CookiePLMonster

CookiePLMonster Aug 30, 2019

Contributor
Suggested change
resolution_options.append(QString::asprintf("%dx Native (%dx%d)", scale,
resolution_options.append(QString("%1x Native (%2x%3)").arg(QString::number(scale),
QString::number(static_cast<int>(EFB_WIDTH) * scale),
QString::number(static_cast<int>(EFB_HEIGHT) * scale));

Qt docs do not recommend using asprintf and recommend using arg instead.

This comment has been minimized.

Copy link
@JosJuice

JosJuice Aug 30, 2019

Contributor

The string should use tr.

@MayImilae

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

I've been using this PR exclusively. This is SO NICE, and fixes a genuine bug too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.