Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DolphinQt: Don't overwrite >8x IR scale in ini, add maximum internal res option #8340

Merged
merged 1 commit into from Apr 17, 2020

Conversation

stenzek
Copy link
Contributor

@stenzek stenzek commented Aug 30, 2019

This adds an ini-only setting under GFX.ini -> [Settings] -> MaxInternalResolution. Setting this will allow the user to select resolutions beyond the default 8x max scale in graphics options.

Also fixes the bug if a user had a >8xIR set, opening the graphics window would overwrite the value, and save it to the ini.

Requested by @MayImilae.

@MayImilae
Copy link
Contributor

I've been using this PR exclusively. This is SO NICE, and fixes a genuine bug too!

@jordan-woyak
Copy link
Member

I don't like the idea of a setting that exposes additional settings in the UI. Can we eliminate the ini overwrites without the meta-setting?

@MayImilae
Copy link
Contributor

The reason for the meta-setting is that it allows power users to expose more options in the GUI (and the tremendous convenience boost it offers) without exposing it to the majority of users.

As an 8k display user, I can tell you, the situation right now is rubbish. Even if the bug of setting internal resolution to -1 is fixed, having to set the internal resolution in the INI exclusively is a paaaain. No one wants to deal with that! But we also shouldn't expose 12x native in the GUI, since the majority of our user base will not be helped by it at all and may be hurt by it (a number of users set it to maximum for no reason). This is a good middle ground: convenience for the bleeding edge, but also no effect on the majority of users.

@jordan-woyak
Copy link
Member

Like was mentioned in IRC, I think adding a "Custom" choice to the drop-down which exposes a numeric entry is a better solution.

…res option

This adds an ini-only setting under GFX.ini -> [Settings] ->
MaxInternalResolution. Setting this will allow the user to select
resolutions beyond the default 8x max scale in graphics options.
@stenzek
Copy link
Contributor Author

stenzek commented Sep 30, 2019

I like the idea of a custom box as well. But I'd rather make that a separate change as it's much more invasive, and we'd need to figure out the best way to warn users that high internal resolutions may not function on their hardware. To do this, we could query the GPU for the maximum texture size, but that depends on having the device created to query features, and in the case of the GL backend refactoring initialization to do so.

Copy link
Contributor

@MayImilae MayImilae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a UX perspective, this is a great change. It allows any internal resolution without breaking if you dare touch the UI, and it also doesn't expose 20x native to users who might try to use it as SSAA or something. This is probably not our final solution, but it fixes bugs and is a genuinely improved user experience. It's a step in the right direction.

@JMC47 JMC47 merged commit 9de3717 into dolphin-emu:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
6 participants