Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DolphinQt: GeckoCodeWidget remove double space #8342

Merged
merged 1 commit into from Sep 1, 2019

Conversation

@dreamsyntax
Copy link
Contributor

commented Sep 1, 2019

One line change.
Removes the double space in the read-only GeckoCodeWidget view.

Before:
XXXXXXXX  XXXXXXXX

After:
XXXXXXXX XXXXXXXX

The before is annoying for those trying to share GeckoCodes.

@dreamsyntax dreamsyntax changed the title DolphinQt: GeckoCodeWidget Remove Double Space DolphinQt: GeckoCodeWidget remove double space Sep 1, 2019

@@ -165,7 +165,7 @@ void GeckoCodeWidget::OnSelectionChanged()
m_code_view->clear();

for (const auto& c : code.codes)

This comment has been minimized.

Copy link
@BhaaLseN

BhaaLseN Sep 1, 2019

Member

I realize this is pre-existing code, but would you mind adding curlies to this; since the contents of the for loop spans over multiple lines?

This comment has been minimized.

Copy link
@dreamsyntax

dreamsyntax Sep 1, 2019

Author Contributor

done

@Helios747 Helios747 merged commit b0a5a9f into dolphin-emu:master Sep 1, 2019

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.