Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove XAudio2 #8361

Merged
merged 2 commits into from Oct 6, 2019

Conversation

@ligfx
Copy link
Contributor

commented Sep 14, 2019

Audio on Windows is provided by the cubeb (shared mode) and WASAPI (exclusive mode) backends, both of which exhibit lower latency.

What to do about users who have XAudio2 configured? Dolphin could:

  • Ignore the problem. Users who upgrade would need to change their backend manually.
  • Automatically use the default backend instead if XAudio2 is configured
  • Automatically use the default backend instead if any unknown backend is configured

I went with the third option here, but happy to implement any of the others.

ligfx added 2 commits Sep 14, 2019
Audio on Windows is provided by the cubeb (shared mode) and WASAPI
(exclusive mode) backends, both of which exhibit lower latency.
Copy link
Member

left a comment

Removing unnecessary things is fine by me.

@stenzek stenzek merged commit dba7f33 into dolphin-emu:master Oct 6, 2019
10 checks passed
10 checks passed
default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
@dreamsyntax

This comment has been minimized.

Copy link
Contributor

commented Oct 6, 2019

After upgrading while my config was set to XAudio2

It now has "No Audio Output" as the Audio Backend, but sound still works as normal.
Is this intended?

Edit:
The above is a bug.

If I change the config to Cubeb then back to "No Audio Output" audio will no longer be present (as intended).

@JosJuice

This comment has been minimized.

Copy link
Contributor

commented Oct 6, 2019

Thanks for the report. Fixed in PR #8392.

@stenzek stenzek referenced this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.