Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WatchWidget: Fix integer comparison signedness warnings #8376

Merged
merged 1 commit into from Oct 24, 2019

Conversation

@tkln
Copy link
Contributor

tkln commented Oct 1, 2019

Fixes integer comparison signedness warnings.

@lioncash

This comment has been minimized.

Copy link
Member

lioncash commented Oct 1, 2019

NUM_COLUMNS should likely be changed to an int. The change as is doesn't resolve signedness conversions, but rather moves them elsewhere. e.g. QTableWidget's setItem function expects an int for its row and column arguments, however this change now passes in an unsigned int.

@CookiePLMonster

This comment has been minimized.

Copy link
Contributor

CookiePLMonster commented Oct 1, 2019

Also I fail to see how this change fixes "enumeration value not handled in switch"? Seems like commit and PR refer to two different warnings.

@tkln tkln force-pushed the tkln:watch-widget-sign-compare branch 2 times, most recently from 6983e34 to a5113e3 Oct 3, 2019
Fixes integer comparison signedness warnings.
@tkln tkln force-pushed the tkln:watch-widget-sign-compare branch from a5113e3 to e3e682c Oct 3, 2019
@tkln

This comment has been minimized.

Copy link
Contributor Author

tkln commented Oct 3, 2019

@CookiePLMonster True, that is for another commit which I somehow got mixed up with this PR.
@lioncash That's indeed a better solution. I've pushed a version that does just that.

@lioncash lioncash merged commit c6da1f0 into dolphin-emu:master Oct 24, 2019
10 checks passed
10 checks passed
default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.